Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Add argument$target toContainerBuilder::registerAliasForArgument()#60910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if ($container->hasAlias($internalAliasId)) { | ||
| $container->getAlias($internalAliasId)->setDeprecated('symfony/framework-bundle','7.3',\sprintf('The "%%alias_id%%" autowiring alias is deprecated and will be removed in 8.0, use "%s $%s" instead.',RateLimiterFactoryInterface::class,(newTarget($name.'.limiter'))->getParsedName())); | ||
| } | ||
| $factoryAlias->setDeprecated('symfony/framework-bundle','7.3','The "%alias_id%" autowiring alias is deprecated and will be removed in 8.0, use "RateLimiterFactoryInterface" instead.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's better to use a short RateLimiterFactoryInterface, that's the only thing that one needs to change when upgrading.
Status: needs work This creates a convention that AutowirePass cannot handle at the moment. |
…gisterAliasForArgument()`
a7bd15e intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
This makes the API simpler and fixes
debug:autowiring, which now displays e.g.: