Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Notifier] accept any PSR-14 event dispatcher implementation#60905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
xabbuh commentedJun 26, 2025
Q | A |
---|---|
Branch? | 7.4 |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Issues | Fix#60885 (comment) |
License | MIT |
Can you also update AbstractTransportFactory? I agree either we decide the BC break won't have any impact (because we consider nobody is going to redeclare the prop in a child class, which might be fine) - or we'd better not do the change. |
I guess I tend to rather not doing the change at all. Not so much because of someone redeclaring the property but about how the property is passed to concrete |
nicolas-grekas commentedJun 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ah, all transports would need the same change indeed. |