Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] accept any PSR-14 event dispatcher implementation#60905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xabbuh wants to merge1 commit intosymfony:7.4fromxabbuh:pr-60885

Conversation

xabbuh
Copy link
Member

QA
Branch?7.4
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#60885 (comment)
LicenseMIT

@xabbuh
Copy link
MemberAuthor

@stof Based on your suggestion in#60885. I am just not sure if it's worth it though as we cannot easily change the type inAbstractTransportFactory without breaking backwards compatibility for child classes.

@nicolas-grekas
Copy link
Member

Can you also update AbstractTransportFactory? I agree either we decide the BC break won't have any impact (because we consider nobody is going to redeclare the prop in a child class, which might be fine) - or we'd better not do the change.

@xabbuh
Copy link
MemberAuthor

I guess I tend to rather not doing the change at all. Not so much because of someone redeclaring the property but about how the property is passed to concreteAbstractTransport implementations created by such a factory.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJun 26, 2025
edited
Loading

Ah, all transports would need the same change indeed.
Let's close then. If someone cares with a real-world use case we might reconsider.

xabbuh reacted with thumbs up emoji

@xabbuhxabbuh deleted the pr-60885 branchJune 26, 2025 08:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

3 participants
@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp