Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Fix implicit to and from bool type juggling#60890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
d7109ac
4212ed9
90c0a98
d0834ee
d387c49
ad4fd82
2ee80c5
6190e42
9997d96
78f4f10
de4c7d5
17ab127
f677c74
90401c0
85de1ec
72b9650
aa67b63
2317f30
4edbb43
2017a7b
e816540
8afc277
4d883cc
218a4f8
5397577
dfcef56
a828919
52dec0e
f3286e3
fa063a6
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -51,7 +51,7 @@ public function registerContainerConfiguration(LoaderInterface $loader): void | ||
$container->register(StaticExtensionWithAttributes::class, StaticExtensionWithAttributes::class) | ||
->setAutoconfigured(true); | ||
$container->register(RuntimeExtensionWithAttributes::class, RuntimeExtensionWithAttributes::class) | ||
->setArguments([true]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. given that | ||
->setAutoconfigured(true); | ||
$container->setAlias('twig_test','twig')->setPublic(true); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -336,7 +336,7 @@ public function testProcessFailsOnPassingClassToScalarTypedParameter() | ||
(newCheckTypeDeclarationsPass(true))->process($container); | ||
} | ||
publicfunctionxtestProcessSuccessOnPassingBadScalarType() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. why skipping this test ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I stole this from@nicolas-grekas WIP commit:nicolas-grekas@02e3881 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. 🙈 | ||
{ | ||
$container =newContainerBuilder(); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -396,13 +396,13 @@ public function handleError(int $type, string $message, string $file, int $line) | ||
$silenced = 0 === ($level & $type); | ||
// Strong errors are not authorized to be silenced. | ||
$level |= \E_RECOVERABLE_ERROR | \E_USER_ERROR | \E_DEPRECATED | \E_USER_DEPRECATED; | ||
$log =(bool) ($this->loggedErrors & $type); | ||
$throw =(bool) ($this->thrownErrors & $type & $level); | ||
$type &= $level | $this->screamedErrors; | ||
// Never throw on warnings triggered by assert() | ||
if (\E_WARNING === $type && 'a' === $message[0] && 0 === strncmp($message, 'assert(): ', 10)) { | ||
$throw =false; | ||
Girgias marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
} | ||
if (!$type || (!$log && !$throw)) { | ||
@@ -472,7 +472,7 @@ public function handleError(int $type, string $message, string $file, int $line) | ||
} | ||
if ($this->isRecursive) { | ||
$log =false; | ||
} else { | ||
try { | ||
$this->isRecursive = true; | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -51,7 +51,6 @@ public static function getInvalidNames() | ||
{ | ||
return [ | ||
[''], | ||
[null], | ||
]; | ||
} | ||
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.