Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Revert " Emit PHP warning whenResponse::sendHeaders() is called while output has already been sent"#60875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:7.3fromnicolas-grekas:hf-header-revert-warningJun 23, 2025
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Response::sendHeaders() is called while output has already been sent"Response::sendHeaders() is called while output has already been sent"ecb09ea intosymfony:7.3 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas added a commit that referenced this pull requestJun 23, 2025
…()` after headers have already been sent (nicolas-grekas)This PR was merged into the 7.4 branch.Discussion----------[HttpFoundation] Deprecate using `Request::sendHeaders()` after headers have already been sent| Q | A| ------------- | ---| Branch? | 7.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITSibling to#60875 to account for#60603Commits-------6f6fdf0 [HttpFoundation] Deprecate using `Request::sendHeaders()` after headers have already been sent
This was referencedJun 23, 2025
robert-stanciu commentedJun 26, 2025
When will this be released? |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commitcf554e1, reversing changes made to392d0c9.
Let's revert as this change is too disruptive for a minor version (and I'm also going to replace this by a deprecation on 7.4 so that we can throw the warning in 8.0)