Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update GitHub PR template#60872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

javiereguiluz
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

Proposed changes:

  • Make some instructions more concise and actionable
  • Emphasize that PRs without a proper description are discouraged
  • Add a few emojis; not for decoration, but to improve visual separation and readability

alexandre-daubois, alamirault, and Kocal reacted with thumbs up emoji
@javiereguiluzjaviereguiluz added this to the6.4 milestoneJun 23, 2025
@carsonbotcarsonbot modified the milestones:6.4,7.4Jun 23, 2025
@carsonbot

This comment was marked as resolved.

@javiereguiluzjaviereguiluz changed the base branch from7.4 to6.4June 23, 2025 06:51
@javiereguiluzjaviereguiluz modified the milestones:7.4,6.4Jun 23, 2025
@mttsch
Copy link
Contributor

As I have been removing some deprecated code for 8.0, I was also always wondering how to fill out the table: It is no bug fix, it is no (new) feature, and it is also no deprecation, because it resolves the deprecation. Not sure if you would really somehow include this case to help filling out the table. (Setting everything to "no" also looks "weird" …)

@nicolas-grekas
Copy link
Member

@mttsch that's usually a feature. Signs of feature include need for a changelog line and need for a doc update. Removing (deprecated) features need both.

mttsch reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@javiereguiluz.

@nicolas-grekasnicolas-grekas merged commit8cfe9b3 intosymfony:6.4Jun 26, 2025
1 check was pending
@javiereguiluzjaviereguiluz deleted the tweak_github_template branchJune 26, 2025 07:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@javiereguiluz@carsonbot@mttsch@nicolas-grekas@alexandre-daubois
[8]ページ先頭
©2009-2025 Movatter.jp