Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Ldap][Security] Remove deprecatederaseCredentials() from (User|Token)Interface#60742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eraseCredentials() from (User|Token)InterfaceeraseCredentials() from (User|Token)Interface9127d07 toe1ed824Compare| // announce the authentication token | ||
| $authenticatedToken =$this->eventDispatcher->dispatch(newAuthenticationTokenCreatedEvent($authenticatedToken,$passport))->getAuthenticatedToken(); | ||
| if ($this->eraseCredentials) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we might need a plan to remove the property now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You mean deprecating on 7.4?
UPGRADE-8.0.md Outdated
| ```php | ||
| #[\Deprecated] | ||
| public function eraseCredentials(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't this method be removed here?
e1ed824 to7909077Compare7909077 to513a272CompareThank you@chalasr. |
46aa500 intosymfony:8.0Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
We didn't deprecate the config option + container parameter from SecurityBundle nor the corresponding
AuthenticatorManagerconstructor param, I propose to keep them no-op and deprecate them in 8.1 (mainly becauseAuthenticatorManageralready deprecates a boolean parameter in 7.3 which makes deprecating the parameter complicates the bc layer and upgrade path significantly).