Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpClient] Remove support for amphp/http-client < 5#60712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 22 commits intosymfony:8.0fromnicolas-grekas:hc-amp5
Jun 5, 2025

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?8.0
Bug fix?yes
New feature?yes
Deprecations?no
Issues-
LicenseMIT

alexandre-dauboisand others added11 commitsJune 4, 2025 09:44
…ath::key()` (alexandre-daubois)This PR was merged into the 7.3 branch.Discussion----------[JsonPath] Always use brackets notation with `JsonPath::key()`| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fixsymfony#60664| License       | MITAs explained in the issue, the dot notation can lead to invalid paths when used with some identifiers (for example, when it contains a `-`). The issue gives the following example:```phpuse Symfony\Component\JsonPath\JsonCrawler;use Symfony\Component\JsonPath\JsonPath;$jsonPathExpression = (string) (new JsonPath)->key('some-prop');dump((new JsonCrawler('{"some-prop": "example value"}'))->find($jsonPathExpression));```Let's always use the brackets notation in `JsonPath::key()`. Dot notation is only a shorthand to the verbose brackets version and this solves the problem without having to do further analysis on the key.Added a few tests to ensure the brackets notation works well too.Commits-------442970b [JsonPath] Always use brackets notation with `JsonPath::key()`
…las-grekas)This PR was merged into the 7.3 branch.Discussion----------[Security] Keep roles when serializing tokens| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fixsymfony#60656,Fixsymfony#60687| License       | MITLooks like I missed something insymfony#59558Commits-------8092ffd [Security] Keep roles when serializing tokens
…earDownAfterClass (cquintana92)"This reverts commitec76ab4, reversingchanges made tobc88600.
…fterClass (cquintana92)This PR was submitted for the 7.4 branch but it was squashed and merged into the 6.4 branch instead.Discussion----------[FrameworkBundle] ensureKernelShutdown in tearDownAfterClass| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | None| License       | MITComes fromsymfony#60564This PR performs the following change: In `KernelTestCase`, the kernel is shut down after every test, as per the `static::ensureKernelShutdown()` call in the `tearDown` function. However, if one was to perform any extra code in their `tearDownAfterClass` and call `getContainer`, it would boot up a new kernel, which would then be left dangling. The main issue with that is that when the next Test class is executed, there would already be a booted kernel, so it could happen that it was pointing to dangling resources.By adding this call to `static::ensureKernelShutdown` in the `tearDownAfterClass`, we can ensure that no dangling kernels are left even after the test class has finished.Commits-------c193b98 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass
…eprecation messages (dheineman)This PR was merged into the 7.3 branch.Discussion----------[WebProfilerBundle] Fix typos in routing config deprecation messages| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITFixes some typos in the deprecation messages introduced insymfony#60232.Commits-------2547946 [WebProfilerBundle] Fix typos in routing config deprecation messages

if (!interface_exists(DelegateHttpClient::class)) {
thrownew \LogicException('You cannot use "Symfony\Component\HttpClient\AmpHttpClient" as the "amphp/http-client" package is not installed. Try running "composer require amphp/http-client:^4.2.1".');
thrownew \LogicException('You cannot use "Symfony\Component\HttpClient\AmpHttpClient" as the "amphp/http-client" package is not installed. Try running "composer require amphp/http-client:^5".');
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also fixed on 7.4 asdc09be9

@nicolas-grekasnicolas-grekasforce-pushed thehc-amp5 branch 3 times, most recently from4a450b2 toc6bf4dcCompareJune 5, 2025 15:30
* 6.4:  cs tweak  [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass  Revert "bugsymfony#60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)"
* 7.2:  cs tweak  [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass  Revert "bugsymfony#60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)"
…ult (nicolas-grekas)This PR was merged into the 7.3 branch.Discussion----------[HttpClient] Suggest amphp/http-client v5 by default| Q             | A| ------------- | ---| Branch?       | 7.3| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITCommits-------851c22c [HttpClient] Suggest amphp/http-client v5 by default
* 7.3:  [HttpClient] Suggest amphp/http-client v5 by default  [WebProfilerBundle] Fix typos in routing config deprecation messages  cs tweak  [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass  Revert "bugsymfony#60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)"  [Security] Keep roles when serializing tokens  [JsonPath] Always use brackets notation with `JsonPath::key()`
…olas-grekas)This PR was merged into the 7.4 branch.Discussion----------[Security] conflict with event-subscriber v8| Q             | A| ------------- | ---| Branch?       | 7.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MIT`Http\Firewall` doesn't have return types in v7.4 to make upgrades smoother, but this also means that this class is not compatible with `EventSubscriberInterface` v8 since we added return types there.Commits-------542cc71 [Security] conflict with event-subscriber v8
* 7.4:  [HttpClient] Suggest amphp/http-client v5 by default  [Security] conflict with event-subscriber v8  Fix leftover  [WebProfilerBundle] Fix typos in routing config deprecation messages  cs tweak  [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass  Revert "bugsymfony#60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)"  [Security] Keep roles when serializing tokens  [JsonPath] Always use brackets notation with `JsonPath::key()`
@nicolas-grekasnicolas-grekas merged commit5a700f2 intosymfony:8.0Jun 5, 2025
6 of 8 checks passed
@nicolas-grekasnicolas-grekas deleted the hc-amp5 branchJune 5, 2025 15:46
@fabpotfabpot mentioned this pull requestOct 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@carsonbot@alexandre-daubois@cquintana92@dheineman@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp