Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpClient] Add response status code helper#60605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jimmy-martin wants to merge1 commit intosymfony:7.4Choose a base branch fromjimmy-martin:feature/http-client-add-response-status-code-helper
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[HttpClient] Add response status code helper#60605
jimmy-martin wants to merge1 commit intosymfony:7.4fromjimmy-martin:feature/http-client-add-response-status-code-helper
+294 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…ommon HTTP status codes
ed1ebac
tobf2eae5
Compareantonkomarev commentedJun 1, 2025
Maybe it's not the Symfony way, but a bit of another proposal. // opt-out from exception to manually check$data =$response->toArray(false);if ($response->status()->isNotFound()) {// not found} |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a set of expressive helper methods to simplify HTTP status code checks on
ResponseInterface
objects that useCommonResponseTrait
trait.These new methods allow developers to write more readable and intention-revealing code when working with
HttpClient
.Before:
After:
I've intentionally selected the most common status codes to keep this initial set focused and practical.
That said, I'm open to feedback on:
PS: This is my 1st PR to Symfony.