NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpClient] Add response status code helper#60604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

jimmy-martin wants to merge1 commit intosymfony:7.3fromjimmy-martin:feature/add-response-status-code-helper

Closed

[HttpClient] Add response status code helper#60604

jimmy-martin wants to merge1 commit intosymfony:7.3fromjimmy-martin:feature/add-response-status-code-helper

Conversation

Copy link

jimmy-martin commentedMay 31, 2025

Q	A
Branch?	7.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	-
License	MIT

This PR adds a set of expressive helper methods to simplify HTTP status code checks onResponseInterface objects that useCommonResponseTrait trait.

These new methods allow developers to write more readable and intention-revealing code when working withHttpClient.

Instead of manually inspecting the status code:

// opt-out from exception to manually check$data =$response->toArray(false);if (404 ===$response->getStatusCode()) {// not found}

You could use it like this:

// opt-out from exception to manually check$data =$response->toArray(false);if ($response->isNotFound()) {// not found}

I've intentionally selected the most common status codes to keep this initial set focused and practical.

That said, I'm open to feedback on:

the naming of the trait (ResponseStatusCodeTrait)
whether we should add more methods (e.g., 418 😉) or remove less useful ones
alternative implementation styles, if more in line with Symfony conventions.

[HttpClient] AddResponseStatusCodeTrait that allows to check for c…

277e57e

…ommon HTTP status codes

carsonbot added Status: Needs Review Feature HttpClient labels

May 31, 2025

carsonbot added this to the7.3 milestone

May 31, 2025

Copy link

carsonbot commentedMay 31, 2025

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot