Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] CleanUp UserInterface PHPDoc#60575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

AboulhajHakim
Copy link

@AboulhajHakimAboulhajHakim commentedMay 28, 2025•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Issues--
LicenseMIT

This PR removes outdated or potentially misleading references to passwords from the PHPDoc comments in the UserInterface. Since the interface does not directly handle password logic, these mentions are unnecessary and could cause confusion for implementers.

Changes:

  • Removed password-related text from PHPDoc comments in UserInterface.

Reasoning:

  • Clarifies the responsibilities of UserInterface.
  • Ensures documentation is aligned with actual interface behavior.

No functional code changes have been made—this is purely a documentation cleanup.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titledoc: CleanUp UserInterface PHPDoc[Security] doc: CleanUp UserInterface PHPDocMay 28, 2025
@nicolas-grekasnicolas-grekas changed the title[Security] doc: CleanUp UserInterface PHPDoc[Security] CleanUp UserInterface PHPDocMay 28, 2025
@nicolas-grekasnicolas-grekas modified the milestones:7.4,7.3,6.4May 30, 2025
@nicolas-grekas
Copy link
Member

Thank you@AboulhajHakim.

makraz reacted with hooray emojiAboulhajHakim reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit383eede intosymfony:6.4May 30, 2025
9 of 11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@AboulhajHakim@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp