Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Uid] Add InvalidUidException Context#60557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rela589n wants to merge2 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromrela589n:invalid-uid-exception

Conversation

rela589n
Copy link
Contributor

QA
Branch?7.4
Bug fix?no
New feature?yes (minor)
Deprecations?no
Issues#60328
LicenseMIT

Considering the main purpose of the exceptions - to be logged, it is best to have their context normalized, so that it can be easily processed by special tools (like Graylog, Logstash, etc).

This PR adds context toInvalidUidException so that its value will appear in logs, and also it adds PSR3-interpolation placeholders for uid value where such were absent.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👎 sorry
We already discussed something very similar.
Exception messages shouldn't be optimized for logs.

@rela589n
Copy link
ContributorAuthor

Sorry

I'm just asking to reconsider it

Actually I thought that it was your point that exception messages are primary for logs, and that's why value is concatenated

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

3 participants
@rela589n@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp