Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Uid] Add InvalidUidException Context#60557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👎 sorry
We already discussed something very similar.
Exception messages shouldn't be optimized for logs.
Sorry I'm just asking to reconsider it Actually I thought that it was your point that exception messages are primary for logs, and that's why value is concatenated |
Considering the main purpose of the exceptions - to be logged, it is best to have their context normalized, so that it can be easily processed by special tools (like Graylog, Logstash, etc).
This PR adds context to
InvalidUidException
so that its value will appear in logs, and also it adds PSR3-interpolation placeholders for uid value where such were absent.