Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Add intl-icu fallback for MessageCatalogue metadata#60549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4frompontus-mp:fix-icu-metadata
May 29, 2025

Conversation

pontus-mp
Copy link
Contributor

@pontus-mppontus-mp commentedMay 26, 2025•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#60523
LicenseMIT

Added domain fallback for metadata, which should match the behavior used for fetching messages.

matyo91 reacted with rocket emoji
@welcoMattic
Copy link
Member

welcoMattic commentedMay 28, 2025•
edited
Loading

Congrats@pontus-mp on your 1st contribution here!

In order to propagate properply the fix, could you update your PR to target the 6.4 branch?
Therefore, the fix will be propagated by up-merge of 6.4 into 7.2 and 7.3.

Thank you

@welcoMatticwelcoMattic changed the base branch from7.2 to6.4May 28, 2025 08:20
@welcoMatticwelcoMattic changed the base branch from6.4 to7.2May 28, 2025 08:21
@pontus-mppontus-mp changed the base branch from7.2 to6.4May 28, 2025 09:00
@pontus-mp
Copy link
ContributorAuthor

In order to propagate properply the fix, could you update your PR to target the 6.4 branch?

Sure! Does everything look correct now?

welcoMattic reacted with thumbs up emoji

@fabpotfabpot modified the milestones:7.2,6.4May 29, 2025
@fabpot
Copy link
Member

Thank you@pontus-mp.

@fabpotfabpot merged commita36cfd8 intosymfony:6.4May 29, 2025
10 of 11 checks passed
This was referencedMay 29, 2025
@pontus-mppontus-mp deleted the fix-icu-metadata branchMay 30, 2025 07:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@ycerutoycerutoyceruto left review comments

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@pontus-mp@welcoMattic@fabpot@OskarStark@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp