NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[AssetMapper] add "full" type for packages to download all content#60545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

eltharin wants to merge2 commits intosymfony:7.4

base:7.4

Choose a base branch

fromeltharin:assetmapper_ad_full_type

Open

[AssetMapper] add "full" type for packages to download all content#60545

eltharin wants to merge2 commits intosymfony:7.4fromeltharin:assetmapper_ad_full_type

Conversation

Copy link

Contributor

eltharin commentedMay 26, 2025•
edited
Loading

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Issues	Fix ##59791
License	MIT

This PR allow AssetMApper to deal with "no modules" libraries,
When we want to require a JS/CSS lib witch doen't have js module, we must import all files to download them.
But in a furthurer version, if one file is added or removed we can skip it.

With the new type "full", Assetmapper can read package contents files and download all of them.

create tests
Add documentation
Add flex change for importmap require from bundle

carsonbot added Status: Needs Review Feature labels

May 26, 2025

carsonbot added this to the7.3 milestone

May 26, 2025

Copy link

carsonbot commentedMay 26, 2025

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot