Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Messenger: add--duration option tomessenger:stop-workers command#60517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Conversation
carsonbot commentedMay 22, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Please add a line in the changelog. Please use 7.4 there, as 7.3 is already in feature freeze 🥶 It looks that your committer email is not associated with your GitHub account, you might want to check this. |
3c603a7 to779fcb2Compare| 7.4 | ||
| --- | ||
| * Add`--duration` option to`messenger:stop-workers` command to keep workers in paused state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| * Add`--duration` option to`messenger:stop-workers` command to keep workers in paused state. | |
| * Add`--duration` option to`messenger:stop-workers` command to keep workers in paused state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done :)
--duration option tomessenger:stop-workers commandc906cdc tob604d41Compareb604d41 to60b0c31Compare| @@ -44,6 +48,11 @@ protected function configure(): void | |||
| Each worker command will finish the message they are currently processing | |||
| and then exit. Worker commands are *not* automatically restarted: that | |||
| should be handled by a process control system. | |||
| Use the --duration option to keep the workers in a paused state (not processing messages) for the given duration (in seconds). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Usethe --duration option to keep the workers in a paused state (not processing messages) for the given duration (in seconds). | |
| Use the<comment>--duration</comment> option to keep the workers in a paused state (not processing messages)for the given duration (in seconds). |
| @@ -35,7 +37,9 @@ public function __construct( | |||
| protectedfunctionconfigure():void | |||
| { | |||
| $this | |||
| ->setDefinition([]) | |||
| ->setDefinition([ | |||
| newInputOption('duration','d', InputOption::VALUE_REQUIRED,'Duration in seconds to keep the workers stopped'), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| newInputOption('duration','d', InputOption::VALUE_REQUIRED,'Duration in secondsto keep theworkersstopped'), | |
| newInputOption('duration','d', InputOption::VALUE_REQUIRED,'Duration in secondsduring whichworkersare paused (not processing messages)'), |
| $this->restartSignalCachePool->save($cacheItem); | ||
| $io->success('Signal successfully sent to stop any running workers.'); | ||
| if ($duration >0) { | ||
| $io->info(sprintf('Workers will be stopped for next %s seconds.',$duration)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| $io->info(sprintf('Workers will bestopped for next %s seconds.',$duration)); | |
| $io->info(sprintf('Workers will bepaused for %s seconds.',$duration)); |
| if ($this->shouldRestart()) { | ||
| $event->getWorker()->stop(); | ||
| $remainingStopSeconds =ceil($this->getEndOfStopTime()) -time(); | ||
| $this->logger?->info(sprintf('Worker is stopped and message processing is paused for the next %d seconds.',$remainingStopSeconds)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| $this->logger?->info(sprintf('Workerisstopped and message processingis paused for the next %d seconds.',$remainingStopSeconds)); | |
| $this->logger?->info(sprintf('The workerispaused and message processingwill resume in %d seconds.',$remainingStopSeconds)); |
Uh oh!
There was an error while loading.Please reload this page.
Hi!
My proposal is to add a
--durationoption to themessenger:stop-workerscommand, which would allow to "pause" the workers for the amount of time specified in this option.For example, if we pass
--duration=10, then for the next 10 seconds, runningmessenger:consumewill return a message indicating how many seconds are left until the "pause" ends.I think this option would be helpful during deployments (we're using it this way in my company).