Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Fix memory leak withmailer.message_logger_listener#60515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
andrew-demb wants to merge1 commit intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromandrew-demb:50580-memory-leak

Conversation

andrew-demb
Copy link
Contributor

@andrew-dembandrew-demb commentedMay 22, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#50580
LicenseMIT

Registermailer.message_logger_listener only when profiler enabled to prevent memory leaks as suggested in:

@stof can you guide me about the way how to implement your second suggestion too?#50580 (comment)

This change may be considered as a minor BC break - DI service won't be available anymore with disabled profiler.

@carsonbotcarsonbot added this to the7.3 milestoneMay 22, 2025
@carsonbotcarsonbot changed the title📦 [#50580] Memory leak withmailer.message_logger_listener[Mailer] 📦 [#50580] Memory leak withmailer.message_logger_listenerMay 22, 2025
@OskarStarkOskarStark changed the title[Mailer] 📦 [#50580] Memory leak withmailer.message_logger_listener[Mailer] Fix memory leak withmailer.message_logger_listenerMay 22, 2025
@@ -4,6 +4,7 @@ CHANGELOG
7.3
---

* `mailer.message_logger_listener` now registered in DI only when profiler enabled to prevent memory leaks
Copy link
Contributor

@OskarStarkOskarStarkMay 22, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not needed if this is considered a bugfix

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure whether it is a bugfix

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

... because solution is about to dropping service from DI container when profiler is disabled

@andrew-demb
Copy link
ContributorAuthor

CI failure is unrelated

1) Symfony\Component\HttpClient\Tests\AmpHttpClientTest::testNonBlockingStreamFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@-'<1>'+''/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php:128

@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

[Mailer] Memory leaking when sending many emails
4 participants
@andrew-demb@OskarStark@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp