Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console][Messenger] Fix: AllowUnrecoverableExceptionInterface to bypass retry inRunCommandMessageHandler#60507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
santysisi wants to merge1 commit intosymfony:6.4
base:6.4
Choose a base branch
Loading
fromsantysisi:fix/unrecoverable-exception-bypass-retry

Conversation

santysisi
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#60427
LicenseMIT

This PR ensures thatUnrecoverableExceptionInterface exceptions thrown during the execution of a command viaRunCommandMessage are no longer retried.

valtzu reacted with thumbs up emoji
@carsonbotcarsonbot added this to the6.4 milestoneMay 22, 2025
@OskarStarkOskarStark changed the title[Console][Messenger] Fix: Allow UnrecoverableExceptionInterface to bypass retry in RunCommandMessageHandler[Console][Messenger] Fix: AllowUnrecoverableExceptionInterface to bypass retry inRunCommandMessageHandlerMay 22, 2025
@valtzu
Copy link
Contributor

valtzu commentedMay 24, 2025
edited
Loading

Shouldn't we do the same forRecoverableExceptionInterface also?

@kbond
Copy link
Member

Shouldn't we do the same for RecoverableExceptionInterface also?

Indeed, I forgot about that one.

@santysisi
Copy link
ContributorAuthor

I don't think we need to do the same forRecoverableExceptionInterface, because when an exception implements that interface, it signals that the operationshould be retried. With this new behavior, we're explicitly avoiding retries for exceptions that implementUnrecoverableExceptionInterface, so the distinction remains meaningful.

@valtzu
Copy link
Contributor

valtzu commentedMay 24, 2025
edited
Loading

@santysisiRecoverableExceptionInterface enforces the retry regardless of what retry strategy says – f.e.max_retries may be reached, but if recoverable exception was thrown, the message must still be retried.

RecoverableExceptionInterface can also override the retry delay set by retry strategy – so ignoring it here would mean always using retry delay from the retry strategy, which would again be unintended/unexpected behavior.

santysisi reacted with heart emoji

@santysisi
Copy link
ContributorAuthor

Got it, thanks for the explanation! I'll make that change. 🙌

valtzu reacted with heart emoji

…pass retry in RunCommandMessageHandlerCo-authored-by: Kevin Bond <kevinbond@gmail.com>
@santysisisantysisiforce-pushed thefix/unrecoverable-exception-bypass-retry branch fromc726fc0 to6d550d8CompareMay 24, 2025 19:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@santysisi@valtzu@kbond@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp