Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console][Messenger] Fix: AllowUnrecoverableExceptionInterface
to bypass retry inRunCommandMessageHandler
#60507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
UnrecoverableExceptionInterface
to bypass retry inRunCommandMessageHandler
valtzu commentedMay 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Shouldn't we do the same for |
Indeed, I forgot about that one. |
I don't think we need to do the same for |
valtzu commentedMay 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@santysisi
|
Got it, thanks for the explanation! I'll make that change. 🙌 |
…pass retry in RunCommandMessageHandlerCo-authored-by: Kevin Bond <kevinbond@gmail.com>
c726fc0
to6d550d8
Compare
This PR ensures that
UnrecoverableExceptionInterface
exceptions thrown during the execution of a command viaRunCommandMessage
are no longer retried.