Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[PhpUnitBridge] Fix cleaning up mocked features with attributes#60500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| @@ -50,35 +52,51 @@ public function bootstrap(Configuration $configuration, Facade $facade, Paramete | |||
| $facade->registerSubscriber(new RegisterClockMockSubscriber($reader)); | |||
| $facade->registerSubscriber(new EnableClockMockSubscriber($reader)); | |||
| $facade->registerSubscriber(new class implements ErroredSubscriber { | |||
| $facade->registerSubscriber(new class($reader) implements ErroredSubscriber { | |||
| public function __construct(private AttributeReader $reader) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The reason I wanted to use the same instance of the reader was to leverage its internal cache. Perhaps moving thedisableClockMock,disableDnsMock, andhasGroup methods to an abstract subscriber class would be better?
Uh oh!
There was an error while loading.Please reload this page.
looking at the CI failure we should probably also exclude the |
990d750 to62da782Compare@xabbuh Don't know why I didn't do that from the start:https://github.com/symfony/symfony/compare/990d750552cd0e84af2d55076805a35ac99ea615..62da782fd3941e75bf150a52eebb6935623ad814 |
Thank you@HypeMC. |
f3247fd intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Fixes usage of the attributes introduced in#59384 to reflect changes made in#60484.