Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpCache] Add awaiting trace when finding the cache locked#60498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+41 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTestCase.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot requested changesMay 30, 2025
| protected function createStore(): Store | ||
| { | ||
| return new Store(sys_get_temp_dir() . '/http_cache'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| returnnewStore(sys_get_temp_dir() .'/http_cache'); | |
| returnnewStore(sys_get_temp_dir().'/http_cache'); |
fabpot approved these changesMay 30, 2025
Thank you@mpdude. |
1152edf intosymfony:7.4 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
waitingtrace that will be recorded by theHttpCachewhen the cache had to wait for another, concurrent request to the same resource to finish first.The information can be used for profiling - a high rate of
waitingrequests means there is a lot of concurrency, so that it might be beneficial to either speed up request processing or consider usingstale-while-revalidate.