NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Messenger] fix: Add argument as integer#60494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromoverexpOG:fix/add_argument_as_integer

May 23, 2025

Merged

[Messenger] fix: Add argument as integer#60494

fabpot merged 1 commit intosymfony:6.4fromoverexpOG:fix/add_argument_as_integer

May 23, 2025

+1 −0

Conversation

Copy link

Contributor

overexpOG commentedMay 20, 2025

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

Description

Added an argument ('x-delivery-limit') to the ARGUMENT_AS_INTEGER array. This change was made to ensure compatibility with RabbitMQ, as the argument was previously being sent as a string, which caused errors. By adding it to the ARGUMENT_AS_INTEGER array, the argument is now properly sent as an integer instead of a string, resolving the issue.

fix: Add argument as integer

4cdbbe5

Co-authored-by: Guillermo Fuentes <guillermofuentesquijada@gmail.com>

carsonbot added Status: Needs Review Bug Messenger labels

May 20, 2025

carsonbot added this to the6.4 milestone

May 20, 2025

Copy link

carsonbot commentedMay 20, 2025

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot