NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[ObjectMapper] added earlier skip to allow if=false when using source mapping#60491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.3frommaciekpaprocki:7.3

May 20, 2025

Merged

[ObjectMapper] added earlier skip to allow if=false when using source mapping#60491

nicolas-grekas merged 1 commit intosymfony:7.3frommaciekpaprocki:7.3

May 20, 2025

Conversation

Copy link

Contributor

maciekpaprocki commentedMay 20, 2025•
edited
Loading

Q	A
Branch?	7.3
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Currently when using object mapper from source if seems to fail if the oiginal source class doesn't have this field.

Which means

class A {public$id =1}class B {  #[Map(source:'id')]public$id = null#[Map(if:false)]  public$additionalInfo = null}$objectMapper->map(newA(),newB());

will fail because there's no property available in A.

Moving the if statement up in the object mapper solves the issue if #Map(if: false). It doesn't support full "IF" logic as it's dependent on value, but I think that's all right. Don't really see why someone would need that if there's no mapping value either way.

carsonbot added Status: Needs Review Bug labels

May 20, 2025

carsonbot added this to the7.3 milestone

May 20, 2025

Copy link

ContributorAuthor

maciekpaprocki commentedMay 20, 2025

Hey!
Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 bug fix". Could you update the PR description or change target branch? This helps core maintainers a lot.
Cheers!
Carsonbot

Sorry bot, misspelling :)

also, for whover is reviewing. I didn't add changelog as i think object mapper for now on is in preview. Please let me know if you would like me to add that.

xabbuh added the ObjectMapper label

May 20, 2025

carsonbot changed the title~~added earlier skip to allow if=false when using source mapping~~[ObjectMapper] added earlier skip to allow if=false when using source mapping

May 20, 2025