Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarDumper] Add support for adding more default casters toAbstractCloner::addDefaultCasters()#60480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lyrixx wants to merge1 commit intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromlyrixx:var-dump-add-caster

Conversation

lyrixx
Copy link
Member

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

This PR let us to write better code, and we also get a better discovery

Kocal reacted with heart emoji
@carsonbotcarsonbot added this to the7.3 milestoneMay 19, 2025
@lyrixxlyrixx changed the titleAdd support for adding more default castors toAbstractCloner::addDefaultCasters()Add support for adding more default casters toAbstractCloner::addDefaultCasters()May 19, 2025
@carsonbotcarsonbot changed the titleAdd support for adding more default casters toAbstractCloner::addDefaultCasters()[VarDumper] Add support for adding more default casters toAbstractCloner::addDefaultCasters()May 19, 2025
@lyrixxlyrixxforce-pushed thevar-dump-add-caster branch fromea86493 to632335fCompareMay 20, 2025 08:21
@lyrixx
Copy link
MemberAuthor

Hello everyone. Thanks for the review! I have addressed your comments.

/**
* Adds default casters for resources and objects.
*
* Maps resources or objects types to a callback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
* Maps resourcesorobjects types to a callback.
* Maps resourcesorobject types to a callback.

* Adds default casters for resources and objects.
*
* Maps resources or objects types to a callback.
* Types are in the key, with a callable caster for value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
*Types are in the key, with acallablecaster for value.
*Usetypesas keys andcallablecasters asvalues.

*
* Maps resources or objects types to a callback.
* Types are in the key, with a callable caster for value.
* Resource types are to be prefixed with a `:`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
*Resource typesare to be prefixedwitha `:`,
*Prefix types with`::`,

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark left review comments

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

@fabpotfabpotfabpot requested changes

@mtarldmtarldmtarld approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

7 participants
@lyrixx@fabpot@stof@OskarStark@alexandre-daubois@mtarld@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp