Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Revert Slug constraint#60475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromwouterj:revert-slug-constraint
May 20, 2025

Conversation

wouterj
Copy link
Member

@wouterjwouterj commentedMay 19, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?no
IssuesReverts#58542
LicenseMIT

After an internal discussion, I think it's best to revert the introduction of theSlug constraint:

  • There is no official standard for slugs, or what a slug means exactly. Within Symfony, it would be best to comply with what ourAsciiSlugger is doing, but amore common approach is to only allow lowercase characters.
  • The constraint adds little on top of the existingRegex constraint, especially when using it'sregex option to customize the pattern for slugs.

Considering this, I believe it is always better for applications to be clear on what they allow in a slug using theRegex constraint.

xabbuh, javiereguiluz, Kocal, and smnandre reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.3 milestoneMay 19, 2025
@wouterj
Copy link
MemberAuthor

cc@raffaelecarelle, as the original author of the PR. If there is something we're overlooking or you see value in the constraint that I'm missing, please feel free to share it here so we can consider it.

@xabbuhxabbuh added Validator ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelsMay 19, 2025
@carsonbotcarsonbot changed the titleRevert Slug constraint[Validator] Revert Slug constraintMay 19, 2025
@ajgarlag
Copy link
Contributor

ajgarlag commentedMay 19, 2025•
edited
Loading

I think PR#59383 should be reverted too

fabpot, OskarStark, and chalasr reacted with thumbs up emoji

@94noni
Copy link
Contributor

94noni commentedMay 19, 2025•
edited
Loading

Warning

you must also update/amend the correspondingblogpost otherwise ppl will think its a fail of release no ?

@fabpot
Copy link
Member

PR on 6.4 to remove the translations:#60486

@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commit9ec163b intosymfony:7.3May 20, 2025
11 checks passed
fabpot added a commit that referenced this pull requestMay 20, 2025
This PR was merged into the 6.4 branch.Discussion----------Remove translations for slug validation error| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues        || License       | MITRelated to#60475Commits-------42eb1c0 Remove translations for slug validation error
@fabpotfabpot mentioned this pull requestMay 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@HypeMCHypeMCHypeMC approved these changes

Assignees
No one assigned
Labels
❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: ReviewedValidator
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

10 participants
@wouterj@ajgarlag@94noni@fabpot@stof@derrabus@xabbuh@alexandre-daubois@HypeMC@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp