NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpKernel] ´MapEntityCollection´ concept#60450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

evgenij-vy wants to merge3 commits intosymfony:7.4

base:7.4

Choose a base branch

fromevgenij-vy:MapEntityCollection

Open

[HttpKernel] ´MapEntityCollection´ concept#60450

evgenij-vy wants to merge3 commits intosymfony:7.4fromevgenij-vy:MapEntityCollection

Conversation

Copy link

evgenij-vy commentedMay 18, 2025•
edited by OskarStark
Loading

Q	A
Branch?	7.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix#60451
License	MIT

Hi everybody. It seems that Symfony needed a smart resolver for entity collection.
It's concept, and if it is really interesting for the community, I'll continue working.
Example to use:

publicfunction__invoke(    #[MapEntityCollection(        class: SomeEntity::class,        queryString:'queryString',        queryMapping: ['someQueryProperty' =>'someEntityProperty'],        doctrineParameters: ['entityProperty' =>'someValue'],        filters: [            MyCustomFilter::class,        ],        defaultOrdering: ['id' =>'ASC']    )]iterable$collectionEntity,    #[MapQueryString]QueryStringObject$queryString,){}

MapEntityCollection concept

2e371ef

carsonbot added Status: Needs Review Feature HttpKernel labels

May 18, 2025

carsonbot added this to the7.3 milestone

May 18, 2025

Copy link

carsonbot commentedMay 18, 2025

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedMay 18, 2025

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot