Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Fix declaring field-attr tags in xml config files#60439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.2fromnicolas-grekas:fwb-field-attr
May 16, 2025

Conversation

nicolas-grekas
Copy link
Member

QA
Branch?7.2
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

@carsonbotcarsonbot added this to the7.2 milestoneMay 16, 2025
@nicolas-grekasnicolas-grekas changed the title[FramewokrkBundle] Fix declaring fiel-attr tags in xml config files[FrameworkBundle] Fix declaring fiel-attr tags in xml config filesMay 16, 2025
@OskarStarkOskarStark changed the title[FrameworkBundle] Fix declaring fiel-attr tags in xml config files[FrameworkBundle] Fix declaring field-attr tags in xml config filesMay 16, 2025
@stof
Copy link
Member

Could we add some tests covering both the usage with a singlefield-attr element and with multiple ones, to ensure that both cases works, as it does not use the usualfixXmlConfig() call converting the XML singular name to the plural name used in formats passing an array directly ? I'm still not convinced it works fine.
those tests should be added in FrameworkExtensionTestCase with the fixtures in the 3 formats ensuring consistent compat

@nicolas-grekas
Copy link
MemberAuthor

Test case added (I did some cleanup also)

@nicolas-grekasnicolas-grekas merged commitd7e71fa intosymfony:7.2May 16, 2025
9 of 11 checks passed
@nicolas-grekasnicolas-grekas deleted the fwb-field-attr branchMay 16, 2025 19:17
This was referencedMay 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

3 participants
@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp