Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Validator] let theSlugValidator acceptAsciiSlugger results#60426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMay 15, 2025
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix#58542 (comment) |
| License | MIT |
SlugValidator acceptAsciiSlugger results| /** | ||
| * @testWith ["PHP"] | ||
| * @testWith ["Symfony is cool"] | ||
| * @testWith ["Lorem ipsum dolor sit amet"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nitpick, you may use only onetestWith instead of three, like the other usage above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In fact, it's even required not to repeat the annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Before:
$ php ./phpunit src/Symfony/Component/Validator/Tests/Constraints/SlugValidatorTest.phpPHPUnit 9.6.23 by Sebastian Bergmann and contributors.Testing Symfony\Component\Validator\Tests\Constraints\SlugValidatorTest.............. 14 / 14 (100%)Time: 00:00.059, Memory: 39.02 MBOK (14 tests, 19 assertions)Now:
$ php ./phpunit src/Symfony/Component/Validator/Tests/Constraints/SlugValidatorTest.phpPHPUnit 9.6.23 by Sebastian Bergmann and contributors.Testing Symfony\Component\Validator\Tests\Constraints\SlugValidatorTest................. 17 / 17 (100%)Time: 00:00.047, Memory: 43.86 MBOK (17 tests, 22 assertions)Thank you@xabbuh. |
c0a1a3a intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.