Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] Addstrtotime() toClockMock#60424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jprivet-dev wants to merge3 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromjprivet-dev:phpunit-bridge-clockmock-strtotime

Conversation

jprivet-dev
Copy link

@jprivet-devjprivet-dev commentedMay 15, 2025
edited
Loading

QA
Branch?7.4
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[PHPUnitBridge] Add strtotime() to ClockMock[PhpUnitBridge] Add strtotime() to ClockMockMay 15, 2025
@jprivet-devjprivet-devforce-pushed thephpunit-bridge-clockmock-strtotime branch from9130864 toe391ecbCompareMay 15, 2025 07:00
@jprivet-devjprivet-devforce-pushed thephpunit-bridge-clockmock-strtotime branch frome391ecb to153464bCompareMay 15, 2025 07:05
@OskarStarkOskarStark changed the title[PhpUnitBridge] Add strtotime() to ClockMock[PhpUnitBridge] Addstrtotime() toClockMockMay 15, 2025
@stof
Copy link
Member

This won't make it to 7.3 as we are in feature freeze. It will be for 7.4.

And this new feature needs to be mentioned in the changelog of the component.

jprivet-dev reacted with thumbs up emoji

@jprivet-dev
Copy link
Author

jprivet-dev commentedMay 15, 2025
edited
Loading

Thanks@stof for your feedback :)

And this new feature needs to be mentioned in the changelog of the component.

  • Added

This won't make it to 7.3 as we are in feature freeze. It will be for 7.4.

  • I'm waiting for the 7.4 branch to update this PR.

@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

5 participants
@jprivet-dev@carsonbot@stof@nicolas-grekas@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp