Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Fix collect_denormalization_errors flag in defaultContext#60413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dmbrson wants to merge2 commits intosymfony:6.4
base:6.4
Choose a base branch
Loading
fromdmbrson:fix_59721_collect_denormalization_flag

Conversation

dmbrson
Copy link

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#59721
LicenseMIT

When using theCOLLECT_DENORMALIZATION_ERRORS flag during denormalization, Symfony should collectall errors and report them together in aPartialDenormalizationException.

Here is an example with two expected errors:

finalreadonlyclass Foo{publicfunction__construct(publicstring$bar,public\DateTimeInterface$createdAt,    ) {}}$foo =$this->denormalizer->denormalize(    data: ['createdAt' =>''],    type: Foo::class,);

Expected errors

  1. Failed to create object because the class misses the "bar" property.
  2. The data is either not a string, an empty string, or null; you should pass a string that can be parsed with the passed format or a valid DateTime string.

When the flag is passed via thecontext

$foo =$this->denormalizer->denormalize(    data: ['createdAt' =>''],    type: Foo::class,    context: [        DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS =>true,    ],);

Both errors are correctly collected and returned.

When the flag is set viadefault_context inframework.yaml:

serializer:default_context:collect_denormalization_errors:true

Only one error is returned:
The data is either not a string, an empty string, or null; you should pass a string that can be parsed with the passed format or a valid DateTime string.

#Root Cause
The issue originates in the \src\Symfony\Component\Serializer\Serializer.php,
function normalize :

if (isset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]) ||isset($this->defaultContext[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS])) {    unset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]);$context['not_normalizable_value_exceptions'] = [];$errors = &$context['not_normalizable_value_exceptions'];$denormalized =$normalizer->denormalize($data,$type,$format,$context);}

The first time this block is hit, it checks for the flag either in $context or $defaultContext. If found, it initializes the error array with:

$context['not_normalizable_value_exceptions'] = [];

However, during nested denormalization (e.g., when parsing thecreatedAt field), Symfony re-enters this code path. If the flag was provided viadefaultContext, it is still present on re-entry. Therefore, thenot_normalizable_value_exceptions array is reset again, losing the previously collected errors.

#My Fix

The fix is to enhance the condition with an additional check to ensure the array of errors is not already initialized:

if (    (isset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]) ||isset($this->defaultContext[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]))    && !isset($context['not_normalizable_value_exceptions']))

This ensures the array is only initialized once, preserving previously collected errors in recursive calls, regardless of whether the flag was passed via context or default_context.

freddytqg reacted with hooray emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

2 participants
@dmbrson@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp