Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle] EnsureEmail class exists before using it#60373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 7, 2025
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4,". Cheers! Carsonbot |
| @@ -1067,7 +1067,7 @@ private function addValidationSection(ArrayNodeDefinition $rootNode, callable $e | |||
| ->validate()->castToArray()->end() | |||
| ->end() | |||
| ->scalarNode('translation_domain')->defaultValue('validators')->end() | |||
| ->enumNode('email_validation_mode')->values(Email::VALIDATION_MODES + ['loose'])->end() | |||
| ->enumNode('email_validation_mode')->values((class_exists(Email::class) ? Email::VALIDATION_MODES : ['html5-allow-no-tld', 'html5', 'strict']) + ['loose'])->end() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since I believeemail_validation_mode won't be used ifsymfony/mailer is not installed, maybe we can just keep it empty:
| ->enumNode('email_validation_mode')->values((class_exists(Email::class) ? Email::VALIDATION_MODES: ['html5-allow-no-tld','html5','strict']) + ['loose'])->end() | |
| ->enumNode('email_validation_mode')->values(class_exists(Email::class) ? Email::VALIDATION_MODES+ ['loose'] : [])->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would keep it the way you changed it here for the same reason we keptloose in#60365, let's better be defensive here as we don't know how people configured their applications
Thank you@Kocal. |
166b527 intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I think thedev-tests suite from Symfony UX broke after#60365, see: