Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console] Ensure overridingCommand::execute() keeps priority over__invoke()#60361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks Jérôme!
Thank you@GromNaN. |
ed0a235 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
| }; | ||
| $command->run(new ArrayInput([]), new NullOutput()); | ||
| $this->assertSame('execute', $command->called); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This tests only if it was called, but in theory the other method could be called before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only it was thelast called. I assumed that was enough to cover the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But priority means it should be the first called method, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In practice, only one of them can be called by Command::run()
Implements#60353 (comment)