Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
don't hardcode OS-depending constant values#60356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The values of the SIG* constants depend on the OS.
GromNaN approved these changesMay 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for finding that out.
OskarStark approved these changesMay 6, 2025
fabpot approved these changesMay 7, 2025
Thank you@xabbuh. |
0069734 intosymfony:6.4 15 of 17 checks passed
Uh oh!
There was an error while loading.Please reload this page.
xabbuh added a commit that referenced this pull requestMay 7, 2025
…on is not installed (xabbuh)This PR was merged into the 6.4 branch.Discussion----------[Console] properly skip signal test if the pcntl extension is not installed| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITIn#60356 I missed that the build on Windows running tests without the pcntl extension failed.Commits-------b3cc194 properly skip signal test if the pcntl extension is not installed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values of the
SIG*constants depend on the OS.For example, on macOS the value of the
SIGSYSconstant is 12 and not 31 making the test added in#60168 fail.