Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Serializer] Add CDATA_WRAPPING_NAME_PATTERN support to XmlEncoder#60355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Deltachaos wants to merge1 commit intosymfony:7.4Choose a base branch fromDeltachaos:feature/cdata-names
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+27 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
CDATA_WRAPPING_NAME_PATTERN
support to XmlEncoderThis PR introduces a new option for the Symfony Serializer component's
XmlEncoder
:CDATA_WRAPPING_NAME_PATTERN
.While Symfony already provides
CDATA_WRAPPING_PATTERN
to wrap fieldcontent in CDATA based on a regex match, this new feature enables CDATA wrapping based on thefield name—regardless of the field's content.Example use case:
This ensures that fields named
firstname
orlastname
are always wrapped in CDATA tags, even if their content doesn't match the typical pattern used byCDATA_WRAPPING_PATTERN
.Motivation:
Consistent Output: In many integration scenarios (e.g., with legacy systems, XML consumers, or strict XSD schemas), consumers expect certain fields toalways use CDATA sections—even when their content doesn't require escaping. This option allows for deterministic XML output by name.
Better Control: It separates concerns: one can now configure CDATA-wrapping forcontent-based needs andfield-based policies independently.
Backward Compatible: The feature is fully optional and does not interfere with existing behavior unless the option is explicitly set.