Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Use kebab-case for auto-guessed input arguments/options names#60344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:7.3fromchalasr:console-kebab-args
May 5, 2025

Conversation

chalasr
Copy link
Member

@chalasrchalasr commentedMay 5, 2025•
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

As it is standard for console options/arguments to be named using kebab-case, I propose to map the invoke parameter names using their kebab-case form in the input definition when they are initially camelCased or snake_cased.

@carsonbotcarsonbot changed the title[Console] Use kebab-case for auto-guessed input arguments/options namesUse kebab-case for auto-guessed input arguments/options namesMay 5, 2025
@carsonbotcarsonbot added this to the7.3 milestoneMay 5, 2025
@carsonbotcarsonbot changed the titleUse kebab-case for auto-guessed input arguments/options names[Console] Use kebab-case for auto-guessed input arguments/options namesMay 5, 2025
@chalasrchalasr added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelMay 5, 2025
Copy link
Member

@kbondkbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good call!

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link
Member

@xabbuhxabbuh left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

in fact we need to bump the dependency forsymfony/string to^7.2 (see the low deps failure)

chalasr reacted with thumbs up emoji
@chalasr
Copy link
MemberAuthor

Fixed, thanks!

@wouterj
Copy link
Member

Nice find, thanks Robin!

@wouterjwouterj merged commit76ab38f intosymfony:7.3May 5, 2025
10 of 11 checks passed
@chalasrchalasr deleted the console-kebab-args branchMay 5, 2025 11:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@kbondkbondkbond approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

@mtarldmtarldmtarld approved these changes

@wouterjwouterjAwaiting requested review from wouterj

Assignees
No one assigned
Labels
ConsoleFeature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

9 participants
@chalasr@wouterj@javiereguiluz@kbond@OskarStark@xabbuh@yceruto@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp