Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] document the array shape of the content option#60342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromxabbuh:pr-60140
May 17, 2025

Conversation

xabbuh
Copy link
Member

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?no
IssuesFix#60140 (comment)
LicenseMIT

but I wonder: is it actually correct that$content is an array, according tohttps://www.w3.org/TR/activitystreams-vocabulary/#dfn-content I would have guessed that it needs to be a string or (if it was an array), we would have to call itcontentMap in the payload instead

@xabbuhxabbuh requested a review fromOskarStark as acode ownerMay 4, 2025 20:03
@carsonbotcarsonbot added this to the7.3 milestoneMay 4, 2025
@carsonbotcarsonbot changed the title[Notifier] document the array shape of the content option[Notifier] document the array shape of the content optionMay 4, 2025
@xabbuhxabbuh added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelMay 5, 2025
@stof
Copy link
Member

stof commentedMay 5, 2025

AFAIK, thiscontent option has nothing to do with the activitystreams specification of the W3C. It has to do withsymfony/ux#1853

@stof
Copy link
Member

stof commentedMay 5, 2025

And this means that the type added in this PR is the wrong one.

@xabbuh
Copy link
MemberAuthor

I have no idea how to read the code of the linked pull request in regard to the changes we want to do here. What would be the right array shape to use?

@stof
Copy link
Member

Looking at the typescript types, they actually refer to the options supported by theNotification constructor of the web platform:https://developer.mozilla.org/en-US/docs/Web/API/Notification/Notification#options

@xabbuhxabbuhforce-pushed thepr-60140 branch 2 times, most recently from9cba2a0 to2b9721fCompareMay 12, 2025 09:19
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit94f4d7a intosymfony:7.3May 17, 2025
16 of 17 checks passed
@xabbuhxabbuh deleted the pr-60140 branchMay 17, 2025 08:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alexandre-dauboisalexandre-dauboisalexandre-daubois left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@stofstofAwaiting requested review from stof

Assignees
No one assigned
Labels
Notifier❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

5 participants
@xabbuh@stof@fabpot@alexandre-daubois@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp