Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Form] Addinput=date_point
toDateTimeType
,DateType
andTimeType
#60315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
input=date_point
to DateTimeType, DateType and TimeTypeThe approach makes sense to me. |
src/Symfony/Component/Form/Extension/Core/DataTransformer/DatePointToDateTimeTransformer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Form/Extension/Core/DataTransformer/DatePointToDateTimeTransformer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
cb58650
to521e9cf
CompareI have added DateTimeType and TimeType. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
input=date_point
to DateTimeType, DateType and TimeTypeinput=date_point
toDateTimeType
,DateType
andTimeType
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After Oskar's comment
ksn135 commentedMay 18, 2025
Updated Changelog 7.3 ->7.4. |
src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good to me once this minor comment +@xabbuh's have been addressed
Uh oh!
There was an error while loading.Please reload this page.
Thank you@wkania. |
21c1205
intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Based ondatetime_immutable.
AfterDatePointType andDatePointDateType, it would be great to use Forms without needing to transform values into the DatePoint type manually.
Alternative: Make symfony/clock a hard requirement and refactor the existing DateTimeImmutableToDateTimeTransformer to return a DatePoint instead. This should not introduce any breaking changes.