Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Fix integration with newer versions of Pheanstalk#60308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -520,4 +606,5 @@ public function testSendWithRoundedDelay() | |||
| interface PheanstalkInterface extends PheanstalkPublisherInterface, PheanstalkSubscriberInterface, PheanstalkManagerInterface | |||
| { | |||
| public function disconnect(): void; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Version 5 doesn't include this method in any of its interfaces (probably to avoid a BC break), but the implementation does. Version 7 adds it to the interface.
Thank you@HypeMC. |
0040477 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Follow-up to#60040.
When I updated the Pheanstalk library, I missed the fact that version 4 internally tracked theused/watched tube. This was removed in newer versions, so now every call to
useTube()orwatch()sends a command to Beanstalkd, leading to unnecessary bandwidth consumption.This PR adds simple tracking logic to avoid redundant calls to those functions.