Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Security] Allow enums inSignatureHasher::computeSignatureHash()
#60302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tests? 🙃 |
SignatureHasher::computeSignatureHash()
SignatureHasher::computeSignatureHash()
SignatureHasher::computeSignatureHash()
Only option 2 makes sense to me. If you need your enum to have a canonical scalar representation, you should use a backed enum (that's what they are about).
that's not something we need to detect IMO (your DB would also have issues in such case, and this would require an insane architecture IMO) |
5c6d8d2
to554fb1f
Compare@chalasr@derrabus@stof Ready for review. I've split the PR into 3 commits:
|
Currently, using
remember_me.signature_properties
on a property holding an enum fails with:We can add support for enums in one of three ways:
int|string
)In the current PR I went with option 2, but I'm thinking that option 3 could be better:
Pros:
Cons:
I would welcome feedback here.