Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Notifier][Mercure] Document options in README file#60259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
[Notifier][Mercure] Document options in README file#60259
Conversation
9c70369 to2235584Compare| $chatMessage = new ChatMessage('Contribute To Symfony'); | ||
| $options = new MercureOptions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Given that we decided to not use named arguments in Symfony Docs, could we please add a short comment to explain what does each option mean in this code example? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's also because MercureOptions is diverging from the other option classes
the norm is to have a constructor with only array $options and to then have fluent setters, see existing classes for inspiration
it'd be nice to check all option classes and add some consistency - looks like it might be needed 🙏
Document mercure notifier options in component readme (as others)
symfony/symfony-docs#20857