Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DoctrineBridge] Add newDatePointDateType Doctrine type#60237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Conversation
I removed the direct mentions to avoid notification spam when the PR is merged |
How is it "problematic"? |
@garak For example, Doctrine Migrations for PostgreSQL will generate migrations using the TIMESTAMP type instead of DATE. The schema will never be fully synchronized if you try to force it. Relational databases have dedicated data types for storing DATE and DATETIME, which is why PHP's DateTime is represented by two separate types in Doctrine. |
First of all, thank you for bringing up this topic. Secondly: Naming things is hard.
My proposal: Keep the |
| $format = 'Y-m-d H:i:s.u'; | ||
| $date = '2025-03-03'; | ||
| $actual = $this->type->convertToPHPValue($date, self::getSqlitePlatform()); | ||
| $expected = DatePoint::createFromFormat('!Y-m-d', $date); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TIL about the!:
Resets all fields (year, month, day, hour, minute, second, fraction and timezone information) to zero-like values ( 0 for hour, minute, second and fraction, 1 for month and day, 1970 for year and UTC for timezone information)
Without!, all fields will be set to the current date and time.
@derrabus Ok, so we're leaning more towards Symfony's naming conventions rather than Doctrine's. You contribute a lot to Doctrine, so this is an important note. |
@derrabus After the changes you suggested, this is how it will look. doctrine:dbal:types:date_point:Symfony\Bridge\Doctrine\Types\DatePointTypedate_point_date:Symfony\Bridge\Doctrine\Types\DatePointDateType #[ORM\Column(type:'date_point_date')]public DatePoint$birthday;#[ORM\Column(type:'date_point')]public DatePoint$createdAt; |
acb035e to7d6da09CompareUh oh!
There was an error while loading.Please reload this page.
7d6da09 to31ca901CompareDatePointDateType Doctrine typee5ec79a to9f41419CompareAdded missingtest |
9f41419 toc18da98CompareUpdated Changelog 7.3 ->7.4. |
@carsonbot label Feature |
Just an idea: What about keeping the name add make it configurable instead of having two types? |
…Type` and `TimeType` (wkania)This PR was merged into the 7.4 branch.Discussion----------[Form] Add `input=date_point` to `DateTimeType`, `DateType` and `TimeType`| Q | A| ------------- | ---| Branch? | 7.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues || License | MITBased on [datetime_immutable](https://symfony.com/blog/new-in-symfony-4-1-added-support-for-immutable-dates-in-forms).After [DatePointType](#59900) and [DatePointDateType](#60237), it would be great to use Forms without needing to transform values into the DatePoint type manually.```use Symfony\Component\Form\Extension\Core\Type\DateType;use Symfony\Component\Form\Extension\Core\Type\DateTimeType;use Symfony\Component\Form\Extension\Core\Type\TimeType;use Symfony\Component\Form\Extension\Core\Type\BirthdayType;$builder->add('from', DateType::class, [ 'input' => 'date_point',]);$builder->add('from', DateTimeType::class, [ 'input' => 'date_point',]);$builder->add('from', TimeType::class, [ 'input' => 'date_point',]);$builder->add('from', BirthdayType::class, [ 'input' => 'date_point',]);```Alternative: Make symfony/clock a hard requirement and refactor the existing DateTimeImmutableToDateTimeTransformer to return a DatePoint instead. This should not introduce any breaking changes.Commits-------f1160d6 [Form] Add input=date_point to DateTimeType, DateType and TimeType
…Type` and `TimeType` (wkania)This PR was merged into the 7.4 branch.Discussion----------[Form] Add `input=date_point` to `DateTimeType`, `DateType` and `TimeType`| Q | A| ------------- | ---| Branch? | 7.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues || License | MITBased on [datetime_immutable](https://symfony.com/blog/new-in-symfony-4-1-added-support-for-immutable-dates-in-forms).After [DatePointType](symfony/symfony#59900) and [DatePointDateType](symfony/symfony#60237), it would be great to use Forms without needing to transform values into the DatePoint type manually.```use Symfony\Component\Form\Extension\Core\Type\DateType;use Symfony\Component\Form\Extension\Core\Type\DateTimeType;use Symfony\Component\Form\Extension\Core\Type\TimeType;use Symfony\Component\Form\Extension\Core\Type\BirthdayType;$builder->add('from', DateType::class, [ 'input' => 'date_point',]);$builder->add('from', DateTimeType::class, [ 'input' => 'date_point',]);$builder->add('from', TimeType::class, [ 'input' => 'date_point',]);$builder->add('from', BirthdayType::class, [ 'input' => 'date_point',]);```Alternative: Make symfony/clock a hard requirement and refactor the existing DateTimeImmutableToDateTimeTransformer to return a DatePoint instead. This should not introduce any breaking changes.Commits-------f1160d6617f [Form] Add input=date_point to DateTimeType, DateType and TimeType
@OskarStark
|
Uh oh!
There was an error while loading.Please reload this page.
Doctrine provides bothdate_immutable anddatetime_immutable types. Restricting the conversion of DatePoint only to datetime_immutable is problematic.
New version:
Previouspull request.
Old version:
Therefore, I propose renaming the current DatePointType to DateTimePointType, and introducing a new DatePointType.
Previouspull request.
If this pull request is to be merged, it should be included in version 7.3 to avoid any breaking changes in the future.