Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add PHP config support for routing#60232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:7.3fromfabpot:routing-php-config
Apr 27, 2025

Conversation

fabpot
Copy link
Member

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
Issuesn/a
LicenseMIT

This is the first to stop using XML for the routing configuration provided by core bundles. We did the same for all other configuration files a while ago, so this is really the last step.

smnandre, welcoMattic, sstok, ging-dev, and chapterjason reacted with hooray emojikaznovac, weaverryan, ging-dev, and chapterjason reacted with heart emoji
@stof
Copy link
Member

To avoid maintaining route definition twice, should we make our XML files import the PHP file ?

GromNaN, mtarld, ging-dev, chalasr, and chapterjason reacted with thumbs up emoji

@ro0NL
Copy link
Contributor

ro0NL commentedApr 18, 2025•
edited
Loading

Can we trigger a runtime deprecation? :) (if xml imports php, maybe we can trace that)

@fabpotfabpotforce-pushed therouting-php-config branch 2 times, most recently fromc8b8b19 to88d40c7CompareApril 27, 2025 08:12
@fabpot
Copy link
MemberAuthor

To avoid maintaining route definition twice, should we make our XML files import the PHP file ?

Done

@fabpot
Copy link
MemberAuthor

Can we trigger a runtime deprecation? :) (if xml imports php, maybe we can trace that)

Done (hackish, tell me if there is something "better" as I want the deprecation to be local to the code)

@fabpot
Copy link
MemberAuthor

Recipes updated insymfony/recipes#1407

@fabpotfabpot merged commit90edbbe intosymfony:7.3Apr 27, 2025
9 of 11 checks passed
@fabpotfabpot deleted the routing-php-config branchApril 27, 2025 18:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ycerutoycerutoyceruto approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

5 participants
@fabpot@stof@ro0NL@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp