Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Notifier] Allow to set block_id/value for SlackActionsBlock and SlackButtonBlockElement#60209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Notifier] Allow to set block_id/value for SlackActionsBlock and SlackButtonBlockElement#60209
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedApr 13, 2025
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedApr 13, 2025
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features / 6.4, 7.1, and 7.2 for bug fixes". Cheers! Carsonbot |
92d6fdb
toe687dff
Compare…allow setting value in SlackButtonBlockElement
e687dff
to6c2d27e
Comparesrc/Symfony/Component/Notifier/Bridge/Slack/Block/SlackButtonBlockElement.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Thank you@miloszowi. |
d344208
intosymfony:7.4Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Allow to pass
null
as$url
forSlackActionsBlock
asit is not requiredAllow to set
$value
as it is requiredAllow to set
block_id
toSlackActionsBlock
asit is required