Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Allow to set block_id/value for SlackActionsBlock and SlackButtonBlockElement#60209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

miloszowi
Copy link
Contributor

@miloszowimiloszowi commentedApr 13, 2025
edited by nicolas-grekas
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

Allow to passnull as$url forSlackActionsBlock asit is not required

Allow to set$valueas it is required

Allow to setblock_id toSlackActionsBlock asit is required

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features / 6.4, 7.1, and 7.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@miloszowimiloszowiforce-pushed theslack-notifier-actions-and-button-blocks-improvements branch from92d6fdb toe687dffCompareApril 13, 2025 11:40
…allow setting value in SlackButtonBlockElement
@miloszowimiloszowiforce-pushed theslack-notifier-actions-and-button-blocks-improvements branch frome687dff to6c2d27eCompareApril 13, 2025 12:17
@carsonbotcarsonbot changed the titleAllow to set block_id for SlackActionsBlock and set url to nullable, …[Notifier] Allow to set block_id for SlackActionsBlock and set url to nullable, …Apr 13, 2025
@nicolas-grekasnicolas-grekas changed the title[Notifier] Allow to set block_id for SlackActionsBlock and set url to nullable, …[Notifier] Allow to set block_id for SlackActionsBlock and set url to nullable, allow setting value in SlackButtonBlockElementApr 16, 2025
@nicolas-grekasnicolas-grekas changed the title[Notifier] Allow to set block_id for SlackActionsBlock and set url to nullable, allow setting value in SlackButtonBlockElement[Notifier] Allow to set block_id and value for SlackActionsBlockApr 16, 2025
@nicolas-grekasnicolas-grekas changed the title[Notifier] Allow to set block_id and value for SlackActionsBlock[Notifier] Allow to set block_id/value for SlackActionsBlock and SlackButtonBlockElementApr 16, 2025
@fabpot
Copy link
Member

Thank you@miloszowi.

@fabpotfabpot merged commitd344208 intosymfony:7.4May 29, 2025
7 of 11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

5 participants
@miloszowi@carsonbot@fabpot@nicolas-grekas@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp