Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Workflow] DeprecateEvent::getWorkflow()
method#60195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Workflow] DeprecateEvent::getWorkflow()
method#60195
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like my comment about#[Deprecated]
would apply to the few other cases where we use it.
Alternatively, we could ban it from the codebase. It's not better than the annotation anyway.
We should maybe postpone using it to Symfony 8+, where we won't have to duplicate the runtime notice for PHP <8.4.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
0dd99b3
to09c3175
Compare
The benefit of the native attribute is that PHP will report the deprecation in the place doing the call, not in the method being deprecated, so it gives a better location for the warning (in our system using |
Uh oh!
There was an error while loading.Please reload this page.
09c3175
to5c483fb
Compare5c483fb
to178a01e
Comparero0NL commentedApr 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
im wondering if we can avoid cant we fix |
I means injecting a locator in every workflow. IMHO this is not the respectability of the workflow to do that. I already thought about using a custom event dispatcher, but a bit overkill IMHO. More over, having a generic listener is really rare, so this use case is really limited |
178a01e
to595711c
Compare595711c
to20fbc9c
CompareThank you@lyrixx. |
f2357a0
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
If one has a listener able to run on many workflow, it need to inject a locator