Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Correctly convertSIGSYS to its name#60168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromcs278:sigbaby
Apr 7, 2025

Conversation

cs278
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesN/A
LicenseMIT

Because of aPHP easter egg using theSignalMap::getSignalName() method withSIGSYS results in'SIGBABY' instead of the expected'SIGSYS' being returned.

https://github.com/php/php-src/blob/213949dc340e17b7234c8a753703b1ab455c8585/ext/pcntl/pcntl_arginfo.h#L398-L400

require'vendor/autoload.php';var_dump(Symfony\Component\Console\SignalRegistry\SignalMap::getSignalName(SIGSYS));// string(7) "SIGBABY"

naderman reacted with eyes emoji
@OskarStark
Copy link
Contributor

giphy

@carsonbotcarsonbot changed the titleCorrectly convertSIGSYS to its name[Console] Correctly convertSIGSYS to its nameApr 7, 2025
@nicolas-grekas
Copy link
Member

Thank you@cs278.

@nicolas-grekasnicolas-grekas merged commitaa40689 intosymfony:6.4Apr 7, 2025
9 of 11 checks passed
@cs278cs278 deleted the sigbaby branchApril 7, 2025 20:04
This was referencedMay 2, 2025
fabpot added a commit that referenced this pull requestMay 7, 2025
This PR was merged into the 6.4 branch.Discussion----------don't hardcode OS-depending constant values| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITThe values of the `SIG*` constants depend on the OS.For example, on macOS the value of the `SIGSYS` constant is 12 and not 31 making the test added in#60168 fail.Commits-------3213d88 don't hardcode OS-depending constant values
github-merge-queuebot pushed a commit to Lendable/composer-license-checker that referenced this pull requestMay 13, 2025
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [symfony/console](https://symfony.com)([source](https://redirect.github.com/symfony/console)) | `7.2.5` ->`7.2.6` |[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fconsole/7.2.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fconsole/7.2.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fconsole/7.2.5/7.2.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fconsole/7.2.5/7.2.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>symfony/console (symfony/console)</summary>###[`v7.2.6`](https://redirect.github.com/symfony/console/releases/tag/v7.2.6)[CompareSource](https://redirect.github.com/symfony/console/compare/v7.2.5...v7.2.6)**Changelog**(symfony/console@v7.2.5...v7.2.6)- bug[symfony/symfony#60168](https://redirect.github.com/symfony/symfony/issues/60168)\[Console] Correctly convert `SIGSYS` to its name (@&#8203;cs278)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/Lendable/composer-license-checker).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNjQuMCIsInVwZGF0ZWRJblZlciI6IjM5LjI2NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@cs278@OskarStark@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp