NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.3k

[Cache] Fix proxying third party PSR-6 cache items#60167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromPatchRanger:fix-60160

Apr 7, 2025

Merged

[Cache] Fix proxying third party PSR-6 cache items#60167

nicolas-grekas merged 1 commit intosymfony:6.4fromPatchRanger:fix-60160

Apr 7, 2025

+2 −1

Conversation

Copy link

Contributor

PatchRanger commentedApr 7, 2025

...work with adapter of CacheItemPoolInterface other than \Symfony\Component\Cache\Adapter\AdapterInterface

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#60160
License	MIT

Fixsymfony#60160: ChainAdapter accepts CacheItemPoolInterface, so it…

74debe4

… should work with adapter of CacheItemPoolInterface other than \Symfony\Component\Cache\Adapter\AdapterInterface

carsonbot added Status: Needs Review Bug labels

Apr 7, 2025

carsonbot added this to the6.4 milestone

Apr 7, 2025

Copy link

ContributorAuthor

PatchRanger commentedApr 7, 2025

I could be missing something, but the fail looks totally unrelated to the one-line-change I made 🤔

Copy link

Member

stof commentedApr 7, 2025

this change is legitimate, but it also indicates a gap in test coverage for our ProxyAdapter. The whole point of the ProxyAdapter is to adaptexternal PSR-6 implementations, but the tests of that class are adapting our own ArrayAdapter (and so won't detect cases where the implementation fails for third-party implementations).
@nicolas-grekas do you think we could easily improve the tests of the ProxyAdapter ?