Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpKernel] Do not ignore enum in controller arguments when it has an#[Autowire]
attribute#60165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
…entLocatorsPassWhen moving services injected from the constructor to the controller arguments, I noticed a bug.We were auto wiring an env var to a backed enum like this:```phpclass Foo{ public function __construct( #[Autowire(env: 'enum:App\Enum:SOME_ENV_KEY')] private \App\Enum $someEnum, ) {} public function __invoke() {}}```This works fine with normal Symfony Dependency Injection.But when we switch to controller arguments like this:```phpclass Foo{ public function __invoke( #[Autowire(env: 'enum:App\Enum:SOME_ENV_KEY')] \App\Enum $someEnum, ) {}}```This stops working.The issue is that BackedEnum's are excluded. But this should only be excluded when there is no Autowire attribute.
fa93de7
to5d6a211
Compare This comment was marked as outdated.
This comment was marked as outdated.
nicolas-grekas approved these changesApr 7, 2025
#Autowire]
attribute#[Autowire]
attributealexandre-daubois approved these changesApr 7, 2025
Thank you@ruudk. |
ea60073
intosymfony:6.4 8 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When moving services injected from the constructor to the controller arguments, I noticed a bug.
We were auto wiring an env var to a backed enum like this:
This works fine with normal Symfony Dependency Injection.
But when we switch to controller arguments like this:
This stops working.
The issue is that BackedEnum's are excluded. But this should only be excluded when there is no Autowire attribute.