Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Allow custom timezone inDateTimeNormalizer during denormalization#60153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
frankdekker wants to merge6 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromfrankdekker:PR_59807

Conversation

frankdekker
Copy link

@frankdekkerfrankdekker commentedApr 5, 2025
edited
Loading

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#59807
LicenseMIT

By default theDateTimeNormalizer will denormalize timestamps and date strings that include a timezone toDateTime objects with respective timezone UTC or the timezone from the date string. Even with the context keyTIMEZONE_KEY set, the timezone from the input superceeds the context timezone.

This PR allows to setPRESERVE_CONTEXT_TIMEZONE_KEY context totrue (default:false), which in combination withTIMEZONE_KEY will set the Timezone of the denormalized DateTimes to the given timezone. The timezone from the input will be overwritten.

Documentation

symfony/symfony-docs#20860

OskarStark, bram123, valtzu, and Hanmac reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[WIP][Serializer] Allow custom timezone in DateTimeNormalizer during denormalization[Serializer] [WIP] Allow custom timezone in DateTimeNormalizer during denormalizationApr 5, 2025
@frankdekkerfrankdekker changed the title[Serializer] [WIP] Allow custom timezone in DateTimeNormalizer during denormalization[Serializer] Allow custom timezone in DateTimeNormalizer during denormalizationApr 5, 2025
@frankdekker
Copy link
Author

Possibility of lowering complexity:

There are currently 2 similar blocks of code for$dateTimeFormat and$defaultDateTimeFormat. The first with a bit more error handling. These blocks could be combined with using the dateTimeFormat in something like$dateTimeFormat ?? $defaultDateTimeFormat ?? null.

I was hesistant to do this immediately because i have no idea why there is different error handling for the context $dateTimeFormat.

@OskarStarkOskarStark changed the title[Serializer] Allow custom timezone in DateTimeNormalizer during denormalization[Serializer] Allow custom timezone inDateTimeNormalizer during denormalizationApr 7, 2025
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mtarldmtarldmtarld left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

[Serializer] Allow custom timezone in DateTimeNormalizer during denormalization
4 participants
@frankdekker@carsonbot@mtarld@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp