Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Notifier] [Mercure] Add options#60140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
carsonbot commentedApr 4, 2025
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features". Cheers! Carsonbot |
this PR connect to this PRsymfony/ux#1853 |
Thank you@ernie76. |
8a84530 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
| @@ -29,6 +29,7 @@ public function __construct( | |||
| private ?string$id =null, | |||
| private ?string$type =null, | |||
| private ?int$retry =null, | |||
| private ?array$content =null, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should document the shape supported for that array
…n (xabbuh)This PR was merged into the 7.3 branch.Discussion----------[Notifier] document the array shape of the content option| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | no| New feature? | no| Deprecations? | no| Issues |Fix#60140 (comment)| License | MITbut I wonder: is it actually correct that `$content` is an array, according tohttps://www.w3.org/TR/activitystreams-vocabulary/#dfn-content I would have guessed that it needs to be a string or (if it was an array), we would have to call it `contentMap` in the payload insteadCommits-------9efc702 document the array shape of the content option
Uh oh!
There was an error while loading.Please reload this page.
Add content option to MercureTransport