Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle][RateLimiter] defaultlock_factory toauto#60099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
weaverryan approved these changesApr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So it basically makessymfony/lock optional without needing to setlock_factory: null
Seems like an easy win
yceruto approved these changesApr 2, 2025
fabpot approved these changesApr 3, 2025
Thank you@kbond. |
59d8c63 intosymfony:7.3 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestApr 7, 2025
This PR was merged into the 7.3 branch.Discussion----------[RateLimiter] default `lock_factory` to `auto`Ref:symfony/symfony#60099Closes#20854.This is a small DX improvement so don't think it needs too much explanation.Commits-------eb5f908 [RateLimiter] default `lock_factory` to `auto`
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Currently, when configuring a rate limiter and using the default configured lock factory (
lock.factory), it fails ifsymfony/lockisn't installed. You have to explicitly set it tonullif you want to configure rate limiters without the lock component.This changes the default
lock_factorytoautothen, at compile time, sets it tolock.factoryifsymfony/lockis installed andnullif not.