Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Exclude AsMessenger attribute from services WIP#60082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Nayte91
Copy link

QA
Branch?7.3
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

As I wanted to auto exclude from services some classes based on their attributes (like messenger messages or doctrine entities), in order to simplify default config/services.yaml->services. App/.exclude configuration, and after some discussions with Sir Grekas, it seems that it can be achieved directly from the components' repositories, and by tagging the given attributes to the container's config.

I'm a bit stuck here, as:

  • My test doesn't pass here as I'm not sure how should I articulate it,
  • I'm not sure my changes will be fired when anyone will use the component,

Any advice or tips would be appreciated to finish this! Sorry for my maybe naive questions

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This needs to be done in an Extension class, to be effective before theAttributeAutoconfigurationPass.
I think, the it would be fine in theFrameworkExtension, like#59987

@chalasr
Copy link
Member

chalasr commentedMar 29, 2025
edited
Loading

ActuallyAsMessage is excluded already since#59987.
@Nayte91 I suggest to have a look at the implementation to answer your own questions :)

GromNaN reacted with thumbs up emoji

@Nayte91
Copy link
Author

I just took a look of this PR; Awesome! I learn from what NG coded here. Glad this idea went real, even if it's small ❤️

chalasr reacted with heart emoji

@Nayte91Nayte91 deleted the feature/Messenger-exclude-attribute branchApril 4, 2025 14:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@GromNaNGromNaNGromNaN left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

4 participants
@Nayte91@chalasr@GromNaN@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp