Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Exclude AsMessenger attribute from services WIP#60082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs to be done in an Extension class, to be effective before theAttributeAutoconfigurationPass
.
I think, the it would be fine in theFrameworkExtension
, like#59987
chalasr commentedMar 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I just took a look of this PR; Awesome! I learn from what NG coded here. Glad this idea went real, even if it's small ❤️ |
As I wanted to auto exclude from services some classes based on their attributes (like messenger messages or doctrine entities), in order to simplify default config/services.yaml->services. App/.exclude configuration, and after some discussions with Sir Grekas, it seems that it can be achieved directly from the components' repositories, and by tagging the given attributes to the container's config.
I'm a bit stuck here, as:
Any advice or tips would be appreciated to finish this! Sorry for my maybe naive questions