Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Remove always-true condition on existence of DIAutowire class#60079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Introduced insymfony#45657symfony/dependency-injection 6.4+ is required, so the class always exists
| $type =preg_replace('/(^|[(|&])\\\\/','\1',$target =ltrim(ProxyHelper::exportType($p) ??'','?')); | ||
| $invalidBehavior = ContainerInterface::IGNORE_ON_INVALID_REFERENCE; | ||
| $autowireAttributes =$autowire ?$emptyAutowireAttributes : []; | ||
| $autowireAttributes =null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The variable$autowireAttributes is used in 1 place when$autowire istrue. But still need to be reset on each loop.
chalasr commentedMar 28, 2025
For 7.2? |
GromNaN commentedMar 28, 2025
That's a minor cleanup, not a bug. So I think therule is to merge into 7.3. |
d442a43 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
This condition was introduced in#45657
The class
RegisterControllerArgumentLocatorsPassrequires the DI component, which cannot be < 6.4 due to aconflict rule in composer.json. So theAutoconfigureclass always exists.