Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console] Deprecate returning a non-int value from a\Closure function set viaCommand::setCode()#60076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
\Closure function set viaCommand::setCode()\Closure function set viaCommand::setCode()cedfb80 toafc81afCompare\Closure function set viaCommand::setCode()\Closure function set viaCommand::setCode()\Closure function set viaCommand::setCode()\Closure function set viaCommand::setCode()…t via `Command::setCode()`
fabpot approved these changesMar 29, 2025
nicolas-grekas approved these changesMar 29, 2025
Thank you@yceruto. |
f6b63a2 intosymfony:7.3 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
xabbuh added a commit to xabbuh/symfony that referenced this pull requestMay 7, 2025
Sincesymfony#60076 using a closure as the command code that does not return aninteger is deprecated. This means that our tests can trigger deprecationson older branches when the high deps job is run. This usually is not anissue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var.However, phpt tests are run in a child process where the deprecation errorhandler of the PHPUnit bridge doesn't step in. Thus, for them deprecationsare not silenced leading to failures.
Merged
xabbuh added a commit to xabbuh/symfony that referenced this pull requestMay 7, 2025
Sincesymfony#60076 using a closure as the command code that does not return aninteger is deprecated. This means that our tests can trigger deprecationson older branches when the high deps job is run. This usually is not anissue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var.However, phpt tests are run in a child process where the deprecation errorhandler of the PHPUnit bridge doesn't step in. Thus, for them deprecationsare not silenced leading to failures.
fabpot added a commit that referenced this pull requestMay 8, 2025
This PR was merged into the 6.4 branch.Discussion----------[Runtime] fix tests| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITSince#60076 using a closure as the command code that does not return an integer is deprecated. This means that our tests can trigger deprecations on older branches when the high deps job is run. This usually is not an issue as we silence them with the `SYMFONY_DEPRECATIONS_HELPER` env var. However, phpt tests are run in a child process where the deprecation error handler of the PHPUnit bridge doesn't step in. Thus, for them deprecations are not silenced leading to failures.Commits-------0b3d980 fix tests
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a missing log entry about a deprecation introducedhere, and also deprecates returning a
nullvalue for\Closurecode (which was allowed before) and throwing a\TypeErrorfor the new invokable command, making this consistent with theCommand::execute(): intmethod.